Skip to content

deps: cherry-pick fa4ec9f from V8 upstream - #14608

Closed
jbajwa wants to merge 1 commit into
nodejs:masterfrom
jbajwa:aix_debug_issue
Closed

deps: cherry-pick fa4ec9f from V8 upstream#14608
jbajwa wants to merge 1 commit into
nodejs:masterfrom
jbajwa:aix_debug_issue

Conversation

@jbajwa

@jbajwa jbajwa commented Aug 3, 2017

Copy link
Copy Markdown

Original commit message:

[date] Refactor PosixTimezoneCache for different OS

Follow up on https://codereview.chromium.org/2740353002. Created
PosixDefaultTimezoneCache which is a subclass of PosixTimezoneCache
containing definition of LocalTimezone and LocalTimeOffset which is
separate for different OS.

R=littledan@chromium.org, ulan@chromium.org

BUG=v8:6578
LOG=N

Change-Id: I58342893aeefe79ac50e1df041d614fc473f15bf
Reviewed-on: https://chromium-review.googlesource.com/568686
Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#46604}

Fixes: #14080

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

deps/v8

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Aug 3, 2017
@jbajwa

jbajwa commented Aug 3, 2017

Copy link
Copy Markdown
Author

/cc @bnoordhuis @gireeshpunathil

@gireeshpunathil gireeshpunathil added the aix Issues and PRs related to the AIX platform. label Aug 3, 2017
@jbajwa

jbajwa commented Aug 3, 2017

Copy link
Copy Markdown
Author

@gireeshpunathil
I don't have the permission to kick off the CI jobs. Could you help kicking off these jobs?
CI: https://ci.nodejs.org/job/node-test-commit
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux

bnoordhuis
bnoordhuis approved these changes Aug 3, 2017
View reviewed changes

@bnoordhuis bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Node CI: https://ci.nodejs.org/job/node-test-pull-request/9463/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/837/

Jaideep Bajwa
deps: cherry-pick fa4ec9f from V8 upstream
d3dd706 
Original commit message:

    [date] Refactor PosixTimezoneCache for different OS

    Follow up on https://codereview.chromium.org/2740353002. Created
    PosixDefaultTimezoneCache which is a subclass of PosixTimezoneCache
    containing definition of LocalTimezone and LocalTimeOffset which is
    separate for different OS.

    R=littledan@chromium.org, ulan@chromium.org

    BUG=v8:6578
    LOG=N

    Change-Id: I58342893aeefe79ac50e1df041d614fc473f15bf
    Reviewed-on: https://chromium-review.googlesource.com/568686
    Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
    Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{nodejs#46604}
@jbajwa

jbajwa commented Aug 14, 2017

Copy link
Copy Markdown
Author

@bnoordhuis
Hi Ben, if this PR is good to land could you help with landing it? Also, do we need another set of runs? since I rebased it.
Thanks.

@bnoordhuis

bnoordhuis commented Aug 17, 2017

Copy link
Copy Markdown
Member

Sorry @jbajwa, I thought you had commit access. This PR puts us in the somewhat awkward position that bumping the V8 patch level means our 6.0.53 isn't upstream's 6.0.53.

I fixed it (what's in a name) by bumping both the patch level and the build number. Landed in 8096791, cheers.

@bnoordhuis bnoordhuis closed this Aug 17, 2017
bnoordhuis pushed a commit that referenced this pull request Aug 17, 2017
Jaideep Bajwa @bnoordhuis
deps: cherry-pick fa4ec9f from V8 upstream
8096791 
Original commit message:

    [date] Refactor PosixTimezoneCache for different OS

    Follow up on https://codereview.chromium.org/2740353002. Created
    PosixDefaultTimezoneCache which is a subclass of PosixTimezoneCache
    containing definition of LocalTimezone and LocalTimeOffset which is
    separate for different OS.

    R=littledan@chromium.org, ulan@chromium.org

    BUG=v8:6578
    LOG=N

    Change-Id: I58342893aeefe79ac50e1df041d614fc473f15bf
    Reviewed-on: https://chromium-review.googlesource.com/568686
    Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
    Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#46604}

PR-URL: #14608
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis bnoordhuis mentioned this pull request Aug 18, 2017
Closed
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
Jaideep Bajwa @MylesBorins
deps: cherry-pick fa4ec9f from V8 upstream
a19221e 
Original commit message:

    [date] Refactor PosixTimezoneCache for different OS

    Follow up on https://codereview.chromium.org/2740353002. Created
    PosixDefaultTimezoneCache which is a subclass of PosixTimezoneCache
    containing definition of LocalTimezone and LocalTimeOffset which is
    separate for different OS.

    R=littledan@chromium.org, ulan@chromium.org

    BUG=v8:6578
    LOG=N

    Change-Id: I58342893aeefe79ac50e1df041d614fc473f15bf
    Reviewed-on: https://chromium-review.googlesource.com/568686
    Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
    Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#46604}

PR-URL: #14608
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
Jaideep Bajwa @MylesBorins
deps: cherry-pick fa4ec9f from V8 upstream
bfb97b7 
Original commit message:

    [date] Refactor PosixTimezoneCache for different OS

    Follow up on https://codereview.chromium.org/2740353002. Created
    PosixDefaultTimezoneCache which is a subclass of PosixTimezoneCache
    containing definition of LocalTimezone and LocalTimeOffset which is
    separate for different OS.

    R=littledan@chromium.org, ulan@chromium.org

    BUG=v8:6578
    LOG=N

    Change-Id: I58342893aeefe79ac50e1df041d614fc473f15bf
    Reviewed-on: https://chromium-review.googlesource.com/568686
    Reviewed-by: Daniel Ehrenberg <littledan@chromium.org>
    Commit-Queue: Jaideep Bajwa <bjaideep@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#46604}

PR-URL: #14608
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

MylesBorins commented Sep 20, 2017

Copy link
Copy Markdown
Contributor

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes
@jasnell jasnell jasnell approved these changes
@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees

No one assigned

Labels

aix Issues and PRs related to the AIX platform. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aix: build failure with linker error in debug mode

6 participants

@jbajwa @bnoordhuis @MylesBorins @jasnell @gireeshpunathil @nodejs-github-bot